DeepLearnPhysics / larcv2

MIT License
13 stars 16 forks source link

use the SIGNED long int val for `invalid instance` #44

Closed chenel closed 12 months ago

chenel commented 12 months ago

Otherwise, when the invalid value is written out to storage via mlreco3d on the other end of the pipeline, we'll run into a OverflowError: Python int too large to convert to C long because of a mismatch between numpy.int64 and unsigned long long.

This choice exposes us to a possible niche bug where we might overflow past this invalid value if there are more than approximately 9e18 instances, but that's a risk worth taking :)