Bug fixes, code cleanups [breaking] - Githubissues

DeepLearnPhysics / lartpc_mlreco3d

7 stars 32 forks source link

Bug fixes, code cleanups [breaking] #123

Closed Temigo closed 1 year ago

Temigo commented 1 year ago

Updates to analysis scripts for Michel electron and muon decay (Temigo) Breaking changes from @francois-drielsma :

Bug fix identified in MomentumNet MLP (used by PID) breaks all PID identification weights trained prior to this update
Deprecated parsers removed
Deprecated list-based parser synthax removed

Other fixes/changes from @francois-drielsma :

Compatibility with pytorch 1.12 (new develop.sif container)
Crash in FullChainEvaluator on images with no predicted non-ghost points
Got rid of double precision typing everywhere, reco now lives on float32 end-to-end
Ensure BN/DO layers are in inference mode when a network module is frozen
Cleaned up archived code everywhere