review output_formatter design

drinkingkazu commented 5 years ago

output_formatter may need a review in its design.

minor: currently requires import X for X.py under the module. This can (and better) be avoided.
It assumes sparseconvnet format in general. This should not be the case. A better implementation is to have a separate parsing function to break the scn formatted data, and have that parsing function called by model-specific X.py (since whether scn or not depends on model architecture).
Further, since parsing data is model a part of model as well as anaysis, shouldn't they live in model architecture file? Why are they in separate X.py under output_formatters, which also adds unnecessary book keeping in other places main_funcs.py and trainval.py. Seems bad design?

drinkingkazu commented 5 years ago

data_blob["input_data"] is hard-coded: "input_data" is not a special/required key...
should assert even when len(cfg['training']['gpus']==0, like any other part in this repo use max(1,len(cfg['training']['gpus']))

drinkingkazu commented 5 years ago

DeepLearnPhysics / lartpc_mlreco3d