search

DeepMicroscopy / SlideRunner

SlideRunner is a tool for massive cell annotations in whole slide images
GNU General Public License v3.0
75 stars 10 forks source link

Clarification needed: When adding second label, spot label circle disappears #11

Closed mingrui closed 6 years ago

mingrui commented 6 years ago

Using the spot tool, when adding a second label, the circle disappears.

(The spot circle not generating directly under the mouse is an issue related to my i3 window manager, it does not happen on regular ubuntu, please ignore)

Here is the bug in action: https://drive.google.com/file/d/15vQ4n6LfcNj04k7sH47N6-qFUC-uksmT/view?usp=sharing

Looking at the database, its a successful write: https://drive.google.com/open?id=1PUURbeD8SbDkzpnBhGDjjiY1DVx5fV9B

mingrui commented 6 years ago

Actually, I think this is not a bug...

The circle disappears because if you add a different second label, the there is a difference of opinion between two experts, so the labels cancel each other out.

In the database, the Annotations.agreedClass will be 0

Could we get a clarification if this is the case? Thank you!

maubreville commented 6 years ago

Thanks for this nicely made report. The "agreed class" is always 0 if both annotators disagree. I think that it's however weird, that the unknown labels are turned on by default.

maubreville commented 6 years ago

Do you think it's fixed for you, if unknown class annotations are enabled by default?

mingrui commented 6 years ago

Just tried the update, I think 1. it's much more clear now; 2. The black circle gives me a chance to re-evaluate differences in opinion at a later time.

I think unknown label enabled by default works for me.

Thanks for the update!