Annotate Polygon bug: when dragging the polygon lines disappear - Githubissues

DeepMicroscopy / SlideRunner

SlideRunner is a tool for massive cell annotations in whole slide images

GNU General Public License v3.0

75 stars 10 forks source link

Annotate Polygon bug: when dragging the polygon lines disappear #3

Closed mingrui closed 6 years ago

mingrui commented 6 years ago

Hi, I have another bug to report.

Using the annotate polygon tool, when I start annotating, if I drag the image before closing the polygon, the black lins will disappear. I have to guess the general position of my unfinished annotation before clicking on a new place, then, the previous unfinished polygon lines will reappear.

maubreville commented 6 years ago

I tried to verify this behaviour with the current version, but was unable to. Is it that you'd wish to have the annotation displayed on the overview image?

maubreville commented 6 years ago

Can you give me some insights about your system environment? I tried this on Mac OS and Linux and was unable to reproduce. Whenever I scroll using using the scrollbars or the track-pad, the currently ongoing (black) annotation is shown.

maubreville commented 6 years ago

However, I think that the polygon annotation tool is currently a bit annoying, in that it will prompt too often to finish the annotation ("Annotate as"). Do you agree?

Up to now, we mostly used point annotations (for single cells with similar radius) and circle annotations (when radius was varying). So I guess the usability is a bit targeted towards that. However, I would love to see SlideRunner used in more projects - so I'm keen on improving it.

mingrui commented 6 years ago

Let me find time to do a screen cast to better show my problem.

I'm very glad to hear that you are keen on improving it, I have a shortlist of improvement ideas. I will try to find time to work on some bug fixes, new features and submit pull request if possible. Thx for making this! It's my second day using this and I can already see the usefulness of it!

maubreville commented 6 years ago

That would be excellent! Perhaps you are using some kind of workflow that I never happend to use :-) I am sure we will find out why this occurs.

maubreville commented 6 years ago

BTW: I changed the look&feel of the polygon annotation a bit. Now you have to double-click to end the annotation. Is this usable for you?

mingrui commented 6 years ago

Here is the bug in action: https://drive.google.com/open?id=1zEgWJW7O48yzanhDUspKcYvP9yMx98LY

I am using the latest code

maubreville commented 6 years ago

Thanks so much. This is of course clearly wrong - oddly though, I have never seen this on my machine. I will try to investigate why this could happen.

mingrui commented 6 years ago

I have seen this on two machines I tested with.

Ubuntu 16.04
Ubuntu 18.04 running inside a virtualbox environment

maubreville commented 6 years ago

Thanks again for the screen cast. Now I can see what the cause is - it's more or less an unexpected workflow.

I always used the scroll bars or the trackpad to scroll the image. At least on Mac OS, this is working nicely, but I already suspected it wouldn't work on other systems.

For my cooperation partners at FU Berlin, I implemented a Shift+Drag gesture to move the image while not changing the tool. However, I just found, that this is buggy, too, for the polygon annotation, as it will create additional polygon corners when trying to scroll.

maubreville commented 6 years ago

Hope this fixes the misbehavior.