search

DeepPSP / torch_ecg

Deep learning ECG models implemented using PyTorch
MIT License
172 stars 20 forks source link

Fix potential data overflow #13

Closed wenh06 closed 11 months ago

wenh06 commented 11 months ago

A potential data overflow bug was found in #12. Now data type conversions are made before doing arithmetic operations for the preprocessors.

codecov[bot] commented 11 months ago

Codecov Report

Merging #13 (27236ed) into master (7040d17) will decrease coverage by 0.03%. The diff coverage is 100.00%.

:exclamation: Current head 27236ed differs from pull request most recent head 01c3319. Consider uploading reports for the commit 01c3319 to get more accurate results

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   93.03%   93.01%   -0.03%     
==========================================
  Files         136      136              
  Lines       18191    18194       +3     
==========================================
- Hits        16924    16923       -1     
- Misses       1267     1271       +4
Files Coverage Δ
torch_ecg/_preprocessors/base.py 98.82% <100.00%> (+0.01%) :arrow_up:
torch_ecg/_preprocessors/normalize.py 100.00% <100.00%> (ø)
torch_ecg/_preprocessors/resample.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes