search

DeepPhe / ontologies

The ontologies and models created for the DeepPhe project
1 stars 2 forks source link

TherapeuticProcedure misclassified #19

Open harryhoch opened 6 years ago

harryhoch commented 6 years ago

TherapeuticProcedure contains a subclass restriction

subClassOf (hasRegimen some Medication Statement)

given that TherapeuticProcedure contains radiation therapies, surgeries, and endocrine therapy, suggest that we remove this restriction and place it on a more specific subclass. Reordering direct subclasses of TherapeuticRegimen might be appropriate as well.

DavidHarris56 commented 6 years ago

Hi Harry,

I’m not sure what this means. Can you help me out?

Thanks Dave

From: Harry Hochheiser [mailto:notifications@github.com] Sent: Monday, December 11, 2017 11:14 AM To: DeepPhe/ontologies Cc: Harris, David; Assign Subject: [DeepPhe/ontologies] TherapeuticProcedure misclassified (#19) [EXTERNAL] [Bulk]

TherapeuticProcedure contains a subclass restriction

subClassOf (hasRegimen some Medication Statement)

given that TherapeuticProcedure contains radiation therapies, surgeries, and endocrine therapy, suggest that we remove this restriction and place it on a more specific subclass. Reordering direct subclasses of TherapeuticRegimen might be appropriate as well.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_DeepPhe_ontologies_issues_19&d=DwMCaQ&c=qS4goWBT7poplM69zy_3xhKwEW14JZMSdioCoppxeFU&r=8X4W-IAN4mUMNsabORQg8y4lpYnz9aRcbHYyDDzpxOhpJh8O0fuYJdHedlo9Jfxk&m=a2NcGZqOu6IwAE8D1ap1W-ivolNX4pCz1n7nNyaDnb0&s=RoJu_eKI1WvVEebtCmC4bcq8jXDD-TPh56MwMX7__Tw&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AbeUfwDaf8Xtrt5RZHqiUb33uZZME9X1ks5s-5FVTHgaJpZM4Q9pIt&d=DwMCaQ&c=qS4goWBT7poplM69zy_3xhKwEW14JZMSdioCoppxeFU&r=8X4W-IAN4mUMNsabORQg8y4lpYnz9aRcbHYyDDzpxOhpJh8O0fuYJdHedlo9Jfxk&m=a2NcGZqOu6IwAE8D1ap1W-ivolNX4pCz1n7nNyaDnb0&s=fRj-PsTrEenGPjCEiy0xYRmFxqGIUg2PFoutB6rkF1s&e=.

harryhoch commented 6 years ago

2017-12-12_23-26-41 Dave, if you look at the entry for TherapeuticProcedure in Protege, there is a class restriction hasRegimen some MedicationStatement ( see attached image).

However, if you look at the subclasses of therapeutic procedure you see mastectomy, radiationtherapy, and other fields that don't include Medications, this restriction is not semantically sensible here.

I don't necessarily have a better solution - this whole subtree is a bit of a mess. If you're not sure how to fix it, let's table this until we get a chance to look at it in more detail.