Closed manonreau closed 2 years ago
Totals | |
---|---|
Change from base Build 1094124503: | 0.0% |
Covered Lines: | 1628 |
Relevant Lines: | 2111 |
I have left a few comments but overall it looks good :) Thanks !
I modified the NeuralNet.py
class to skip the input data set in the plotting function if no target is provided. This way no benchmarking mode is required.
Hi @manonreau I pushed two commits (since it's not easy to comment all the details), take a look please :-)
BTW, please also close the related issues after merging the PR :-)
1) Compute grid_shape only if it is not provided as an input
2) Compute the feature_mean if
self.clip_features == True
feature_mean was computed whenself.normalize_features == True
, this is not required anymore.3) Format logger message in the
compute_norm
function4) Allow feature clipping in the
_clip_feature
function only if values exists for that feature5) Add a condition not to transform features values when they correspond to an empty vector in the mapping process
6) set
save_hit_rate
as False by default since it call the IRMSD target that may not be used by the users7) Added plots as optional in the
test()
function since the users, in principle, have no target information for the test set, excepted in benchmark conditions