DeepRank / pdb2sql

Fast and versatile biomolecular structure PDB file parser using SQL queries
https://pdb2sql.readthedocs.io
Apache License 2.0
24 stars 12 forks source link

Add Paths to test folder #48

Closed joaomcteixeira closed 4 years ago

joaomcteixeira commented 4 years ago

The only issue I found was with many2sql which did not accept Path objects, so I used os.fspath to convert Paths to str before. This relates to #30.

Cheers,

NicoRenaud commented 4 years ago

Thanks a lot for your PR @joaomcteixeira ! It looks good to me but @CunliangGeng did most of the testing so I'll ask his review. Thanks again !

joaomcteixeira commented 4 years ago

Hi! This is a technique I use a lot in my projects so it was easy to add it here as well. Cheers! :wink:

joaomcteixeira commented 4 years ago

Thanks and cheers!