DeepRank / pdb2sql

Fast and versatile biomolecular structure PDB file parser using SQL queries
https://pdb2sql.readthedocs.io
Apache License 2.0
24 stars 12 forks source link

Please add backbone selection to compute_lrmsd_pdb2sql() #55

Closed DarioMarzella closed 4 years ago

DarioMarzella commented 4 years ago

Is your feature request related to a problem? Please describe. I would be able to calculate l-RMSD on different atoms of the backbone: only CA, or [CA, C, O, N] or [CA, CB, C, O, N], etc.

Describe the solution you'd like Allowing the user to give a list of atoms to be used for l-RMSD calculation as an optional parameter of compute_lrmsd_pdb2sql

Describe alternatives you've considered This might be appliable to irmsd as well.

NicoRenaud commented 4 years ago

The easiest solution is to pass the selection keyword of pdb2sql.get() down to the compute_lrmsd_pdb2sql() I'm not sure about the fast methods

NicoRenaud commented 4 years ago

first attempt in issue55 branch. we ca use

s.compute_lrmsd_pdb2sql(name=['CA','O'])
s.compute_lrmsd_fast(name=['CA','O'])

if the name kwarg is not specified it defaults to [C, CA, N, O]

NicoRenaud commented 4 years ago

need to be extended to irmsd (?) and cleaned up

CunliangGeng commented 4 years ago

Solved in PR #59