DeepRegNet / DeepReg

Medical image registration using deep learning
Apache License 2.0
569 stars 79 forks source link

New demo for globalnet #536

Closed YipengHu closed 3 years ago

YipengHu commented 4 years ago

Subject of the feature

@jvhoutte suggested to add a demo using the global net predicting affine transformation. The alterntive may be to add an option and trained network in one of the existing demos.

What are you trying to do and how would you want to do it differently?

Still open to suggestions, but simply adding an trained affine network option.

Is this related to an issue/problem? To a bug report #533

Has the feature been requested before? If yes, please provide a link to the issue. no

If the feature request is approved, would you be willing to submit a PR? (Help can be provided if you need assistance submitting a PR)

yes

mathpluscode commented 4 years ago

Which dataset are we considering here? @jvhoutte @YipengHu

YipengHu commented 3 years ago

Suggest:

According to the config here: https://deepreg.readthedocs.io/en/latest/docs/configuration.html#globalnet Not sure it needs to edit any functions at this stage, but the related functions may be here: https://github.com/DeepRegNet/DeepReg/blob/main/deepreg/model/backbone/global_net.py

YipengHu commented 3 years ago

@acasamitjana As a student is interested in looking at #703, are you interested in looking at this ticket instead?

acasamitjana commented 3 years ago

Okey. In your previous comment, are you suggesting to update the paired_ct_lung demo or to create a new one using the same dataset?

YipengHu commented 3 years ago

Okey. In your previous comment, are you suggesting to update the paired_ct_lung demo or to create a new one using the same dataset?

either is fine, maybe start with changing the paired ct? if we identify anything better, we can always update

acasamitjana commented 3 years ago

extract_levels parameter is deprecated. How should we deal with that? Maybe opening an issue targeting some RC milestone? I believe that applies to GlobalNet as well as UNet, right?

YipengHu commented 3 years ago

extract_levels parameter is deprecated. How should we deal with that? Maybe opening an issue targeting some RC milestone? I believe that applies to GlobalNet as well as UNet, right?

GlobalNet should have never used extract_levels. You can safely ignore this for GlobalNet.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.