search

DeepRegNet / DeepReg

Medical image registration using deep learning
Apache License 2.0
569 stars 79 forks source link

Release to docker hub #608

Closed mathpluscode closed 3 years ago

mathpluscode commented 3 years ago

Subject of the feature

We have a preliminary docker file already. As some users might be interested in using deepreg directly inside the docker, to skip all the complicated setup, it's worth considering releasing the docker image to docker hub as well.

This is doable via GitHub Action, but some checks should be enabled in CI first.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

mathpluscode commented 3 years ago

Regarding the docker, I still wonder whether we should have conda inside docker or not.

YipengHu commented 3 years ago

Regarding the docker, I still wonder whether we should have conda inside docker or not.

  • If using nvidia docker images, this should not be required.
  • If using tf docker images, this is probably needed to handle the cuda dependency.

what is the downside of nvidia docker?

mathpluscode commented 3 years ago

Regarding the docker, I still wonder whether we should have conda inside docker or not.

  • If using nvidia docker images, this should not be required.
  • If using tf docker images, this is probably needed to handle the cuda dependency.

what is the downside of nvidia docker?

Probably no downside, but if you do not have GPU, then I'm not sure if you can use a nvidia docker, will dig.

mianasbat commented 3 years ago

Taking liberty to comment, hope you guys do not mind it. I am working on Docker to create CPU and GPU examples here. I noticed that there is no problem to specify nvidia docker for CPU program and therefore I am using it for both examples. It works fine even if GPU is not present on docker host. The minor drawback is that nvidia docker is much larger in size than simple ubuntu which will making sharing a bit difficult.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.