search

DeepRegNet / DeepReg

Medical image registration using deep learning
Apache License 2.0
569 stars 79 forks source link

Complete pylint linting #610

Closed mathpluscode closed 3 years ago

mathpluscode commented 3 years ago

Subject of the code / test

After https://github.com/DeepRegNet/DeepReg/pull/589, we have activated some extra linting rules. However, there are still more rules not respected in the current code base.

As we can see in https://github.com/DeepRegNet/DeepReg/runs/1665498705?check_suite_focus=true, there are still many errors triggered.

Thus it would be nice to split the job and solve the issues one by one. We can either create multiple issues, or use this same issue while maintaining a TODO list.

YipengHu commented 3 years ago

@NMontanaBrown do you think you can handle this?

NMontanaBrown commented 3 years ago

I don't think it's a good use of my time to pylint all the codebase @YipengHu . Rather, I would suggest an auto pylint hook, or ask that people pylint as they go. And then towards the end if we have to, do a quick pylint run with many people.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.