DeepRegNet / DeepReg

Medical image registration using deep learning

Apache License 2.0

564 stars 76 forks source link

635 add auto config transform #636

Closed mathpluscode closed 3 years ago

mathpluscode commented 3 years ago

Description

Add parser to support config at v0.1.1

Fixes #635

Type of change

What types of changes does your code introduce to DeepReg?

Please check the boxes that apply after submitting the pull request.

[x] Bugfix (non-breaking change which fixes an issue)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation Update (fix or improvement on the documentation)
[ ] New feature (non-breaking change which adds functionality)
[ ] Other (if none of the other choices apply)

Checklist

Please check the boxes that apply after submitting the pull request.

If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have installed pre-commit using pre-commit install and formatted all changed files. If you are not certain, run pre-commit run --all-files.
[x] My commits' message styles matches our requested structure, e.g. Issue #<issue number>: detailed message.
[x] I have updated the change log file regarding my changes.
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

mathpluscode commented 3 years ago

This PR is ready now @YipengHu @s-sd @NMontanaBrown

Now we support the v0.1.1 configs.

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@6b362bd). Click here to learn what that means. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main      #636   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        34           
  Lines           ?      2246           
  Branches        ?         0           
========================================
  Hits            ?      2246           
  Misses          ?         0           
  Partials        ?         0

Impacted Files	Coverage Δ
deepreg/config/parser.py	`100.00% <100.00%> (ø)`
deepreg/config/v011.py	`100.00% <100.00%> (ø)`
deepreg/predict.py	`100.00% <100.00%> (ø)`
deepreg/train.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b362bd...4cc30c6. Read the comment docs.

NMontanaBrown commented 3 years ago

Will review this this morning @YipengHu @mathpluscode

scrutinizer-notifier commented 3 years ago

The inspection completed: 22 new issues, 26 updated code elements

mathpluscode commented 3 years ago

Hi @mathpluscode this is a great piece of work, thanks so much. I would recommend a release with this MR on 0.1.1 or 1.0.0-rc1 (whatever numbr we are on) that pre-empts users to this new config change. What do you think?

Yup, I plan to add more docs on registry this week and then let's do a release within one week.