DeepRegNet / DeepReg

Medical image registration using deep learning
Apache License 2.0
564 stars 76 forks source link

Question about IntDVF #665

Closed kate-sann5100 closed 3 years ago

kate-sann5100 commented 3 years ago

Is IntDVF converting DDF to DVF or DVF to DDF. Because base on the DVF network implementation, it seems like IntDVF is converting DVF to DDF while the docstring in Int DVF states otherwise. https://github.com/DeepRegNet/DeepReg/blob/80854094feafec998fa6237199066556c73f31f9/deepreg/model/layer.py#L508-L535

YipengHu commented 3 years ago

@kate-sann5100 well-spotted. it is a typo i believe.

mathpluscode commented 3 years ago

Yup, it's a typo. Will correct it.

mathpluscode commented 3 years ago

Actually, I've fixed it in my PR #656.

mathpluscode commented 3 years ago

With the merge of #656, this issue is now fixed

https://github.com/DeepRegNet/DeepReg/blob/main/deepreg/model/layer.py#L357