Issue #683: test on py36 and 37

[mathpluscode]

Description

Test the code on (py36, py37) x (ubuntu, mac)

Fixes #683

Type of change

What types of changes does your code introduce to DeepReg?

Please check the boxes that apply after submitting the pull request.

• [x] Bugfix (non-breaking change which fixes an issue)
• [ ] Code style update (formatting, renaming)
• [ ] Refactoring (no functional changes, no api changes)
• [x] Documentation Update (fix or improvement on the documentation)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Other (if none of the other choices apply)

Checklist

Please check the boxes that apply after submitting the pull request.

If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• [x] I have installed pre-commit using pre-commit install and formatted all changed files. If you are not certain, run pre-commit run --all-files.
• [x] My commits' message styles matches our requested structure, e.g. Issue #<issue number>: detailed message.
• [x] I have updated the change log file regarding my changes.
• [x] I have added tests that prove my fix is effective or that my feature works
• [ ] I have added necessary documentation (if appropriate)

[codecov[bot]]

Codecov Report

Merging #684 (ae9d027) into main (5e5bbdc) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #684   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         2432      2432           
=========================================
  Hits          2432      2432           

Impacted Files	Coverage Δ
deepreg/model/layer.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e5bbdc...ae9d027. Read the comment docs.

[mathpluscode]

So, I've fixed the issue mentioned in #661.

Moreover, now the code will be tested for py3.6 and py3.7, for ubuntu and macos.

However, to not waste too much energy for nothing, I only trigger

• for unit-test (~10 mins)
  • ubuntu + py3.7
  • ubuntu + py3.6
  • macos + py3.7
• for integration test (~30 mins)
  • ubuntu + py3.7

If later we encounter some problems then, we can cover more cases.

@zacbaum please have a check if this branch solves your problem. Also, please have a look if this impacts the release. In case it does, we can open another issue for that.

Otherwise, @NMontanaBrown @YipengHu feel free to have a look, if there's any doc to be updated.

[zacbaum]

Will take a look in the next few days and give this a test - non-trivial to add custom versions of python packages into Slicer so will need a few days before I get to check this out properly :)

[mathpluscode]

Will take a look in the next few days and give this a test - non-trivial to add custom versions of python packages into Slicer so will need a few days before I get to check this out properly :)

Sure, regarding this PR, may we merge it? As tests are passed:)

As you need to check on your side, I will only close #683 not your issue #661

[NMontanaBrown]

I'll let @zacbaum review this because it might strictly break his builds, so I assume he's the most appropriate person to review.

[mathpluscode]

I'll let @zacbaum review this because it might strictly break his builds, so I assume he's the most appropriate person to review.

This PR should not impact the existing release pipeline, but I agree it's better to wait for @zacbaum ^^

[zacbaum]

Will take a look in the next few days and give this a test - non-trivial to add custom versions of python packages into Slicer so will need a few days before I get to check this out properly :)

Sure, regarding this PR, may we merge it? As tests are passed:)

As you need to check on your side, I will only close #683 not your issue #661

I would prefer to just wait until I know this resolves the issue - that way we don't need another PR, etc.

Better to just do it right the first time!!