DeepRegNet / DeepReg

Medical image registration using deep learning
Apache License 2.0
564 stars 76 forks source link

Issue #613: remove loss weight check in sanity check #688

Closed mathpluscode closed 3 years ago

mathpluscode commented 3 years ago

Description

As now, _build_loss handles the checking and is quite robust. No more need to check losses in sanity checks.

https://github.com/DeepRegNet/DeepReg/blob/main/deepreg/model/network.py#L174

Fixes #613

Type of change

What types of changes does your code introduce to DeepReg?

Please check the boxes that apply after submitting the pull request.

Checklist

Please check the boxes that apply after submitting the pull request.

If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

mathpluscode commented 3 years ago

@YipengHu sorry for the delay. This fix was quite simple in fact.

I've tested the config mentioned in #613, it now works with a warning as expected.

image

Further changes linked to sanity checks will be addressed in https://github.com/DeepRegNet/DeepReg/issues/652

codecov[bot] commented 3 years ago

Codecov Report

Merging #688 (2ca3a81) into main (183d7f8) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #688   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         2432      2424    -8     
=========================================
- Hits          2432      2424    -8     
Impacted Files Coverage Δ
deepreg/config/parser.py 100.00% <ø> (ø)
deepreg/model/network.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 183d7f8...2ca3a81. Read the comment docs.