DeepRegNet / DeepReg

Medical image registration using deep learning
Apache License 2.0
564 stars 76 forks source link

Issue #590: rename log_dir to exp_name and log_root to log_dir #698

Closed mathpluscode closed 3 years ago

mathpluscode commented 3 years ago

Description

Fixes #590

Type of change

What types of changes does your code introduce to DeepReg?

Please check the boxes that apply after submitting the pull request.

Checklist

Please check the boxes that apply after submitting the pull request.

If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

codecov[bot] commented 3 years ago

Codecov Report

Merging #698 (e660b3c) into main (f4422f9) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #698   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         2424      2423    -1     
=========================================
- Hits          2424      2423    -1     
Impacted Files Coverage Δ
deepreg/predict.py 100.00% <100.00%> (ø)
deepreg/train.py 100.00% <100.00%> (ø)
deepreg/util.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f4422f9...e660b3c. Read the comment docs.

mathpluscode commented 3 years ago

So I did

It might be a bit confusing, but now

I've updated the docs correspondingly.

@YipengHu @NMontanaBrown @s-sd would you have time to review this?

mathpluscode commented 3 years ago

we have this docs currently

YipengHu commented 3 years ago

does log_dir has no shorthand '-l' now?