DeepSOIC / Part-o-magic

Experiment on FreeCAD-wide automation of Part container management. For FC v0.17-0.18
Other
12 stars 4 forks source link

Missing icons #50

Open leoheck opened 4 years ago

leoheck commented 4 years ago

Hi @DeepSOIC are you aware of this issue?

https://forum.freecadweb.org/viewtopic.php?f=3&t=50748&p=436827#p436827

Closes #50

DeepSOIC commented 4 years ago

Now i am, thanks for heads-up!

leoheck commented 4 years ago

No problem.

luzpaz commented 3 years ago

@leoheck nice catch. JFYI, if you add Closes #50 in the git commit summary, it will automagically close this ticket when PR is merged

DeepSOIC commented 3 years ago

@luzpaz i suppose you meant to mention @allanlaal, the author of the commit, not @leoheck .

BTW, @leoheck , is the issue fixed for you by the commit? I have just noticed that observer control buttons lost their icons with this fix somehow, so i've reverted it for now.

leoheck commented 3 years ago

I didn't close this because I was not able to check if it works. I will need some hours to be able to confirm, cool @DeepSOIC ?

DeepSOIC commented 3 years ago

sure, no hurry

allanlaal commented 3 years ago

seems that the path needs to be absolute afterall, I've seen how other worksbenches use FreeCAD.Path to get the true local FreeCAD mods path

luzpaz commented 1 year ago

What's the status of this ticket ?

DeepSOIC commented 1 year ago

no changes have been made, so it's probably still bugged.

EDIT: i now have access to a computer with ubuntu 20.04, i might bother to test it!