search

DeepTrackAI / deeplay

Other
4 stars 5 forks source link

Bugs in GANs #103

Closed HarshithBachimanchi closed 4 months ago

JesusPinedaC commented 4 months ago

Hi @HarshithBachimanchi

I've reviewed the changes and I think they look good, especially if the examples work as expected now.

However, I suggest that we implement unit tests for both CycleGAN and DCGAN. This will help us keep track of any possible changes to the models. The unit tests can be quite simple and focus on evaluating the correct order of operations, expected number of layers, and appropriate output dimensions of the model.

HarshithBachimanchi commented 4 months ago

Hi! @JesusPinedaC

I have created the unit tests now, and adjusted few other minor things. The models are working as expected now, and the weights are being initialized properly for dcgan.

If everything looks good, I think this can be merged now.

BenjaminMidtvedt commented 4 months ago

These are excellent unittests! @HarshithBachimanchi

Everything looks good to me.