create vs build, configure, replace

DeepTrackAI / deeplay

Other

5 stars 6 forks source link

create vs build, configure, replace #59

Open cmanzo opened 10 months ago

cmanzo commented 10 months ago

The method module.create() does't overwrite module and requires mymodule = module.create() whereas module.build(), module.configure() and module.replace() do. It makes sense, since create must return a new instance but I believe it can easily produce mistakes.

BenjaminMidtvedt commented 10 months ago

Honestly. I'm considering removing create. It seems to mostly add bugs and be confusing