search

DeepWok / mase

Machine-Learning Accelerator System Exploration Tools
Other
117 stars 52 forks source link

graph.py fix (maybe #28

Closed zniihgnexy closed 7 months ago

zniihgnexy commented 8 months ago

https://github.com/DeepWok/mase/commit/03a5c687f26685c89678ddd9c3ce0bea6f3e06ae

i think there're some old version masegraph tuple problem. i found this when running the search script. from Zheng Xinyi, please corret me if this change doesn't work

Aaron-Zhao123 commented 8 months ago

I cant really see your code somehow, but i belive it is fixed in commit 8bfb024

zniihgnexy commented 8 months ago

thank you for checking this problem.

Aaron-Zhao123 commented 8 months ago

Can you plz double-check on whether this solves your probelm?

zniihgnexy commented 8 months ago

thank you and this error is now fixed. i talked with one of the TAs and we fixed together.

Laurie2905-JOHN commented 8 months ago

I am now getting this error since I have pulled the new changes. I see that the changes made in 8bfb024 are no longer present.

jianyicheng commented 8 months ago

@Laurie2905-JOHN Sorry, we made some mistakes when we updated the files, which caused some previous PRs missed. I have made a fixing patch here: https://github.com/DeepWok/mase/pull/41

Feel free to help fix by submitting your own PRs!