DeepWok / mase

Machine-Learning Accelerator System Exploration Tools
Other
117 stars 52 forks source link

Quantization Pass Bug #30

Closed firemountain154B closed 8 months ago

firemountain154B commented 8 months ago

For this bug, it might happen anywhere when we are trying to modify the call_func or call_method attribute of fx_graph, so it might not only in the quantization pass, I only relinked the quantization pass. I don't know if there is some other place need to be relinked. I've considered relink the whole transform pass, but if relink them all , some places (search) only call the quantizaition pass will still be broken.

Aaron-Zhao123 commented 8 months ago

Interesting, can you populate this to other passes?

firemountain154B commented 8 months ago

Interesting, can you populate this to other passes?

I just checked Pruning pass only do the call_module level transform. Some other transform under passes/graph/transform/utils linked it already, so maybe it just a small missing in the quantization pass - -