Add qt opt - Githubissues

DeepX-inc / machina

Control section: Deep Reinforcement Learning framework

MIT License

279 stars 45 forks source link

Closed takerfume closed 5 years ago

takerfume commented 5 years ago

Finished implementation

rarilurelo commented 5 years ago

Could you apply pep8 to the scripts you changed or added.

takerfume commented 5 years ago

Sorry, I did.

takerfume commented 5 years ago

I fixed code except for returning q in dictionary in argmax_qf_pol.py

rarilurelo commented 5 years ago

Could you add test code to tests/test_algo.py?

takerfume commented 5 years ago

I finished dealing with all comments.

takerfume commented 5 years ago

I forgot adding test. Now I will add.

takerfume commented 5 years ago

I finished dealing with all comments.

takerfume commented 5 years ago

I think I fixed all codes.

rarilurelo commented 5 years ago

Thank you very much! LGTM 👍 Qt-opt will help many types of real world problem, because it is stable, off policy, and for continuous action space.