search

Deepakchawla / Mobile-Phone-Dataset-GSMArena

Python script for creating Mobile Phones Dataset on GSMArena website.
MIT License
59 stars 46 forks source link

Refactor with python3 modules + Add comments #10

Closed Sahil-Ajmera closed 2 years ago

Sahil-Ajmera commented 3 years ago
Deepakchawla commented 3 years ago

@Sahil-Ajmera all looks good except functions outside of class. Please try to put all thing class based.

Sahil-Ajmera commented 3 years ago

@Sahil-Ajmera all looks good except functions outside of class. Please try to put all thing class based.

Done @Deepakchawla

Sahil-Ajmera commented 3 years ago

Hi @Deepakchawla , could you take a look at this PR again.? Thank you.

Deepakchawla commented 3 years ago

@Sahil-Ajmera I looked at your code it seems that you don't put self keyword at variable declaration of the class. So please correct your code. Please maintain the quality of code.

Sahil-Ajmera commented 3 years ago

@Deepakchawla thanks. Updated.

Deepakchawla commented 3 years ago

@Sahil-Ajmera still have so many issues in the code. do you run this code locally before commit?

Sahil-Ajmera commented 3 years ago

@Deepakchawla are you facing issues running code? Can you share the log? The last change I made does not seem destructive to me. I can double check.

Anyway, this PR was to better the code with python 3 things. If this is not working out well I can close and move on. I did not think this would take that long.

Sahil-Ajmera commented 3 years ago

The move from class -> non-class and back to class missed one update. I have corrected that. Thank you @Deepakchawla I have run the code and it is running on my local.

ibnbax commented 3 years ago

can you send the csv database please for 2021

krm1337 commented 3 years ago

can you send the csv database please for 2021

GSMArenaDataset.zip Attached. Not complete, but you can still save a lot of time with it as scraping is pretty slow.

ibnbax commented 3 years ago

can you send the csv database please for 2021

GSMArenaDataset.zip Attached. Not complete, but you can still save a lot of time with it as scraping is pretty slow.

thank you so much samsung is not included

ibnbax commented 3 years ago

thank you so much Samsung brand isn't included can you send for Samsung brand please

On Mon, Feb 1, 2021, 5:23 PM krm1337 notifications@github.com wrote:

can you send the csv database please for 2021

GSMArenaDataset.zip https://github.com/Deepakchawla/Mobile-Phone-Dataset-GSMArena/files/5904383/GSMArenaDataset.zip Attached. Not complete, but you can still save a lot of time with it as scraping is pretty slow.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Deepakchawla/Mobile-Phone-Dataset-GSMArena/pull/10#issuecomment-770888222, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKSTPESCD3ZUOOU7542SBITS42ZRBANCNFSM4VSLPE4A .

krm1337 commented 3 years ago

thank you so much Samsung brand isn't included can you send for Samsung brand please … On Mon, Feb 1, 2021, 5:23 PM krm1337 @.***> wrote: can you send the csv database please for 2021 GSMArenaDataset.zip https://github.com/Deepakchawla/Mobile-Phone-Dataset-GSMArena/files/5904383/GSMArenaDataset.zip Attached. Not complete, but you can still save a lot of time with it as scraping is pretty slow. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKSTPESCD3ZUOOU7542SBITS42ZRBANCNFSM4VSLPE4A .

Like I said it's not complete. Unfortunately scraping is still in progress (very slow). You can start the script yourself and finish scraping database. With the given .zip unpacked to the right folder, it will take much less time.

Sahil-Ajmera commented 3 years ago

@Deepakchawla could you please take a look at this PR when you get a chance? Thank you.