search

DeepanshuGOYAL05 / Techademics

An Online Interaction Portal for Teachers & Students
6 stars 9 forks source link

Passwords are not hashed #18

Open tharindulucky opened 3 years ago

tharindulucky commented 3 years ago

Passwords are currently getting saved in plain text. This is a really really bad practice. Hash the password with a proper hashing function.

DeepanshuGOYAL05 commented 3 years ago

You can do this. I will approve your PR

On Tue, Oct 13, 2020, 10:07 PM Tharindu Lakshitha notifications@github.com wrote:

Passwords are currently getting saved in plain text. This is a really really bad practice. Hash the password with a proper hashing function.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DeepanshuGOYAL05/Techademics/issues/18, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH6TG765TAEQYOCQLDNAVVLSKR63HANCNFSM4SPHIJBA .

tharindulucky commented 3 years ago

OK. I'll start development!

DeepanshuGOYAL05 commented 3 years ago

Sure!!

On Tue, Oct 13, 2020, 10:20 PM Tharindu Lakshitha notifications@github.com wrote:

OK. I'll start development!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/DeepanshuGOYAL05/Techademics/issues/18#issuecomment-707874172, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH6TG75RIYL7ZQILB4N2EG3SKSAMNANCNFSM4SPHIJBA .

tharindulucky commented 3 years ago

@DeepanshuGOYAL05 Mind if I changed the database structure a bit ? Won't changed the functionality though.

DeepanshuGOYAL05 commented 3 years ago

Yeah, No problem!!

On Wed, Oct 14, 2020, 12:04 AM Tharindu Lakshitha notifications@github.com wrote:

@DeepanshuGOYAL05 https://github.com/DeepanshuGOYAL05 Mind if I changed the database structure a bit ? Won't changed the functionality thought.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DeepanshuGOYAL05/Techademics/issues/18#issuecomment-707931218, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH6TG7Z4PCQS3YALPMG7XMDSKSMRTANCNFSM4SPHIJBA .

tharindulucky commented 3 years ago

@DeepanshuGOYAL05 I added a PR with hashed passwords implemented. Please review it and let me know if any thing changed. Thanks!

DeepanshuGOYAL05 commented 3 years ago

I will check it later.

On Wed, Oct 14, 2020, 9:56 PM Tharindu Lakshitha notifications@github.com wrote:

@DeepanshuGOYAL05 https://github.com/DeepanshuGOYAL05 I added a PR with hashed passwords implemented. Please review it and let me know if any thing changed. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DeepanshuGOYAL05/Techademics/issues/18#issuecomment-708514365, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH6TG72JGV2H7AHKZIUMNLDSKXGJXANCNFSM4SPHIJBA .

tharindulucky commented 3 years ago

@DeepanshuGOYAL05 Okay, If it causes no errors and meets your standards, I'd appreciate if you could label the PR with hacktoberfest-accepted. Thanks!

rahulparmani commented 3 years ago

Hi @DeepanshuGOYAL05 I have created a PR relating to this issue #18. Can you please review it. Thanks.