Deepomatic / dmake

DMake is a tool to manage micro-service based applications
MIT License
36 stars 3 forks source link

Add needed_services[].use_host_ports #483

Closed thomas-riccardi closed 3 years ago

thomas-riccardi commented 3 years ago

Useful to force disable host_port when a service is used as a dependency, and still keep this available when that service is directly started; for example a frontend, also started as a dependency of the backend, to support front, back, and both-together development modes.

Add useless host_port and use_host_ports usage in test/*/dmake.yml to cover that part.

This doesn't properly cover all edge cases regarding NeededService specialization: we assume all instances for a service that are otherwise identical are using the same value for use_host_ports. It's undefined behavior to not do that.

Also improve test/*/.dockerignore for faster tests.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication