Add trafaret date and datetime support

Deepwalker / trafaret

Ultimate transformation library that supports validation, contexts and aiohttp.

http://trafaret.readthedocs.org/en/latest/

BSD 2-Clause "Simplified" License

177 stars 31 forks source link

Add trafaret date and datetime support #55

Closed sonerayberk closed 5 years ago

sonerayberk commented 5 years ago

Add Trafaret datetime.date and datetime.datetime support.

Deepwalker commented 5 years ago

We have some existing date related contrib module https://github.com/Deepwalker/trafaret/blob/master/trafaret/contrib/rfc_3339.py Not sure how to resolve competition – what is your opinion?

sonerayberk commented 5 years ago

@Deepwalker Thanks for the feedback!

Here are some pros of the proposal:

Format support;
More specific errors;
Zero Python packages dependency (no dateutil requirement);
Not so primitive data type, but potentially a good idea to have in base.py as specialized Python's data type;
Instant support of Date & DateTime trafarets via pip install trafaret, no pip install trafaret[rfc3339] is required.

Your thoughts?

sonerayberk commented 5 years ago

@Deepwalker Any updates about the PR?

Deepwalker commented 5 years ago

I like this idea Main pros is stdlib only. But I have version2 branch, and will need to update this implementation to include codes etc as well. So I think what to do first, merge PR or release version2.

sonerayberk commented 5 years ago

I can make PR into the version2 branch as well, no problems

sonerayberk commented 5 years ago

@Deepwalker Created PR to version2 https://github.com/Deepwalker/trafaret/pull/58. Will we merge current PR into master or should I close it?

Arfey commented 5 years ago