Deepwalker / trafaret

Ultimate transformation library that supports validation, contexts and aiohttp.
http://trafaret.readthedocs.org/en/latest/
BSD 2-Clause "Simplified" License
177 stars 31 forks source link

Add '1.0' and '0.0' to `ToBool` #98

Closed jona-sassenhagen closed 5 years ago

jona-sassenhagen commented 5 years ago

Reading Excel files in Pandas can result in TRUE turning up as 1.0. This makes it annoying to validate with Trafaret.

Arfey commented 5 years ago

Thx for your contribution 👍 Please don't forget add a test for your case and add description to documentation.

jona-sassenhagen commented 5 years ago

Ok I will! Thanks!

jona-sassenhagen commented 5 years ago

Should I add something to the changelogs?

Arfey commented 5 years ago

I don't think so.

LGTM

jona-sassenhagen commented 5 years ago

Feel free to merge then :)