Closed DeerTears closed 2 years ago
DeerTears
commented
2 years ago 
I saw this message when I was deleting a redundant .mod file and I wonder if this change of line endings is causing the data to be mis-read when converted to instructions for the rom. OpenMPT seems to read these just fine, so I wonder if there's a way to reconvert line-endings on download. That's assuming this is the issue, at least.
DeerTears
commented
2 years ago Excited_Suspense.mod needs fixing.
mxashlynn
commented
2 years ago @DeerTears I can help test mod files. I'll hit you up on Discord
mxashlynn
commented
2 years ago I enabled git lfs for this repo which should prevent the line ending issue from happening again in the future.
I'll use Excited_Suspense.mod as an example and see if I can figure out exactly what the issue is.
As a fallback, I'll resave everything using OpenMPT, though we might need new versions of some of the mods if they are already corrupted....
mxashlynn
commented
2 years ago I tested every .mod in this repo with GB Studio 2.0 beta 5 and all of them now build without error. I believe that re-encoding them for git-lfs must have corrected whatever the corruption problem was. I can't vouch that everything is playing correctly, but I didn't notice anything that sounded obviously wrong.
I'm closing this issue. If we get new reports we can dig deeper!
Some users have reported mod files (some composed by me) that prevent their games from building, even though I've tested nearly every song that's been added. If saving the contents as a new .mod file through OpenMPT doesn't fix these files then I don't know what the problem is or why it's happening to old .mod files.
17 might be a good solution to help prevent this issue from occuring if for some reason storing .mod files on Github causes them to get changed in a way that makes GBT Player unhappy.
Ultimately, it'd be awesome to have help hunting down and noting the names of the .mod files that are problematic in this issue's comments so they can be tested and hopefully fixed.