search

DeerTears / Keep-Away-Game

A multiplayer FPS keep-away game made in Godot. Protect your ballpit from enemy attackers! Prototype out now!
https://deertears.itch.io/keep-away-prototype
Other
6 stars 1 forks source link

Add online multiplayer #2

Closed EineKartoffel103 closed 3 years ago

EineKartoffel103 commented 3 years ago

Hello! I added online multiplayer to the game. There are loads of changes, so here are the most important ones regarding online multiplayer:

Screenshots: online_mp ip cleint-server

DeerTears commented 3 years ago

@EineKartoffel103 Sorry this took so long to comment on. I've been working a lot this past week and I had no idea you were going to dig so deep into this older project of mine. 😅

We could talk sometime about how to move forward if you're really interested in building upon this project even more. I'm on discord at Ember#1765 or you can let me know if there's some other way you prefer to contact people.

There's a lot of half-finished stuff in this codebase that I could remove. Most importantly is that I now have a better sense of how to name things and to keep code to a style, so I'd be looking at refactoring things to follow https://www.gdquest.com/docs/guidelines/best-practices/godot-gdscript/ in the future. This doesn't have to be right now, finishing up your pull request for online multiplayer is more important. I figured here would be the best place to give you my thoughts on the situation if this game really is going to be receiving more development time like this. 😛

EineKartoffel103 commented 3 years ago

Thank you for your feedback! I added a cancel button to the waiting screen and made some changes to the username variable. As for the resolve hostname error, I don't think there's a way of fixing it. You could use the is_valid_ip_adress() function to check the server ip before connecting to it, but that would make it impossible to connect to any servers with a domain (e.g. example.com). create_client() also does not return an error code. However, I think the error should not be an issue anyways since the game keeps running just fine.