Closed ericfilippi closed 4 years ago
Deesen
commented
4 years ago Hi, sorry for the delay. To be honest I also did never use every feature of YAMS so I am not sure how to test them all. I did not develop YAMS on my own, I only took the repository over.
So in case this merge causes issues, it would be great if you can take care of them.
ericfilippi
commented
4 years ago Hi, I created a release on my fork but it didn't sync with yours ... Sorry, I'm not so familiar with GitHub.
https://github.com/ericfilippi/YAMS/releases/tag/v1.3.0
So can you do the same on you side ? I kept "this is a user contrinuted extre" on the doc so people will know that the support will be "best effort" ...
have a good day.
Hello, After a few hours of trying to understand the logic and new Evo CMS v2.0 constraints, I rewrote a part of the plugin code using new Evo CMS API functions such as $modx->getConfig() and $modx->getDocumentObject('id',$docId). I followed the same logic as you did, just replacing deprecated $tmplvars variable by modx API, and using the event "OnDocFormSave" instead of "OnBeforeDocFormSave" because DocumentObject has not the good values before the effective save. So instead of preventing modx to delete empty tvs, I just recreate then afterwards.
Then I reviewed all the YAMS php files for these items :
I performed a couple of tests on my dev site, including activate, deactivate languages, create, modify resources with empty TVs (which was the core issue of new Evo version). But I couldn't perform full tests because I don't have the time and I don't use all YAMs features. this proposed version is running on my prod site and is stable. It has also successfully passed migration from Evo 1.4.11 to Evo 2.0.2 wihout any issue.
I updated the links to the new Evo CMS documentation on GitHub, and I'll propose a pull request for documentation soon. I'll do the same for the new extra repository.