Control whether unmatched files should be returned

hdgarrood commented 7 years ago

Fixes #11

Add a GlobOptions data type which provides a new Bool flag to control whether unmatched files should be included in the results of the globbing functions.
Change globDir to not return unmatched files so that it is more in line with globDir1.
Change globDirWith to accept a GlobOptions rather than a MatchOptions.
Change the result type of globDirWith so that the unmatched files are wrapped in Maybe, in order to easily distinguish the situations where there were no unmatched files vs where the user did not ask for a list of unmatched files to be collected.

These changes provide a significant performance boost in situations where the user doesn't care about the unmatched files, e.g. for functions like glob.

There are no tests covering these changes currently, but I could try to add some if you'd like?

Deewiant commented 7 years ago

I'd certainly be happy to have tests for these functions.

Sorry, I've no time to look at the changes right now but I should be able to review tomorrow.

hdgarrood commented 7 years ago

No rush at all! I'll add some tests soon.

hdgarrood commented 7 years ago

Ok, these tests are quite basic but I think they ought to cover the stuff I've added.

hdgarrood commented 7 years ago

Ok - how does this look now?

Deewiant commented 7 years ago

Looks good, thanks again!

hdgarrood commented 7 years ago

Thanks for the review :)

Deewiant / glob

Control whether unmatched files should be returned #12