search

Deewiant / glob

Haskell library for glob matching
https://deewiant.iki.fi/projects/glob/
Other
25 stars 8 forks source link

Fix name shadowing in System.FilePath.Glob.Base #17

Closed hdgarrood closed 7 years ago

hdgarrood commented 7 years ago

I just realised I accidentally introduced this warning during #14.

Deewiant commented 7 years ago

I guess the Travis setups should be overhauled to check for warnings and HLint violations...

Thanks for noticing this, my testing was evidently a bit sloppy.

hdgarrood commented 7 years ago

I only noticed because ghci on my machine is configured to always show warnings! I think adding ghc-options: -Wall to the cabal file would make this kind of thing easier to spot, and then we could maybe also add -Werror to the travis script.

Deewiant commented 7 years ago

That'd probably make sense, yes.