search

Deewiant / glob

Haskell library for glob matching
https://deewiant.iki.fi/projects/glob/
Other
25 stars 8 forks source link

Add Unmatchable token, fixes #23 #25

Closed hdgarrood closed 7 years ago

hdgarrood commented 7 years ago

Optimize unmatchable patterns to just [Unmatchable], i.e. compile "[.]".

Also strengthen tests for commonDirectory edge cases to ensure that tests fail a little more reliably if this issue is present.

Deewiant commented 7 years ago

Thanks for all the effort you've put in!

hdgarrood commented 7 years ago

Sure thing - thanks for all your reviews! Incidentally I didn’t yet get a chance to try your most recent suggestion for simplifying that function so that would probably be a good place to start if you were going to revisit this.

Deewiant commented 7 years ago

Yep, that was my plan. :-)