search

Deewiant / glob

Haskell library for glob matching
https://deewiant.iki.fi/projects/glob/
Other
25 stars 8 forks source link

Glob.cabal: add missing Utils module to test suite #3

Closed trofi closed 8 years ago

trofi commented 8 years ago

Signed-off-by: Sergei Trofimovich siarheit@google.com

Deewiant commented 8 years ago

Did this omission actually break something?

trofi commented 8 years ago

Lack of required modules in hackage tarballs breaks users who enable building or running upstream tests:

$ cabal unpack glob && cd Glob-* && cabal test
...
[ 2 of 13] Compiling Tests.Utils      ( tests/Tests/Utils.hs, dist/build/glob-tests/glob-tests-tmp/Tests/Utils.o )

tests/Tests/Utils.hs:12:1: error:
    Failed to load interface for ‘Utils’
    it is a hidden module in the package ‘scientific-0.3.4.8’
    it is a hidden module in the package ‘process-extras-0.3.3.8’
    it is a hidden module in the package ‘concurrent-extra-0.7.0.10’
    it is a hidden module in the package ‘Top-1.7’
    Use -v to see a list of the files searched for.

Gentoo has support for testsuite running right after package build.

I usually run tests for released packages when import new versions to Gentoo package tree (or update package dependencies like GHC).

Deewiant commented 8 years ago

Ah, right, the omission means that it's left out from the cabal sdist package! D'oh, that's embarrassing. Thanks for the fix.