Deewiant / glob

Haskell library for glob matching
https://deewiant.iki.fi/projects/glob/
Other
25 stars 8 forks source link

`Glob-0.10.2` fails to build on Windows with GHC 8.0 and earlier #45

Closed RyanGlScott closed 2 years ago

RyanGlScott commented 2 years ago

If I try to build Glob-0.10.2 on Windows with GHC 8.0 or earlier, it fails with:

[1 of 7] Compiling System.FilePath.Glob.Utils ( System\FilePath\Glob\Utils.hs, dist\build\System\FilePath\Glob\Utils.o )
System\FilePath\Glob\Utils.hs:31:1: error:
    Failed to load interface for `System.Win32.String'
    Perhaps you meant
      System.Win32.File (from Win32-2.3.1.1)
      System.Win32.Security (from Win32-2.3.1.1)
      System.Win32.Shell (from Win32-2.3.1.1)
    Use -v to see a list of the files searched for.
cabal.exe: Failed to build Glob-0.10.2 (which is required by bench:bench from text-show-3.9.4). See the build log above for details.

See this CI job for an example. This is happening because System.Win32.String was introduced in Win32-2.5.0.0, but GHC 8.0 comes bundled with Win32-2.3.1.1. Can the lower version bounds on Win32 be raised to >= 2.5 to reflect this? Thanks!

kakkun61 commented 2 years ago

Thank you for your report!

This issue was fixed on the master. https://github.com/Deewiant/glob/commit/4521e278faaa7163cd661fc8987710db4f32e62a

I will release 0.10.3 with this fix and 0.10.2 rev. 3 with Win32 >= 2.5.

RyanGlScott commented 2 years ago

Thanks! I'm eagerly looking forward to this.

kakkun61 commented 2 years ago

I released 0.10.2-r3 with #46. https://hackage.haskell.org/package/Glob-0.10.2