search

DefGuard / client

Best WireGuard desktop client with Multi-Factor Authentication
67 stars 9 forks source link

Fix e0063 #154

Closed NerdvanaExplorer closed 5 months ago

NerdvanaExplorer commented 6 months ago

Changes Made appstate.rs and commands.rs:

Added post_down and pre_down fields to RemoveInterfaceRequest as None. utils.rs:

Added pre_up and post_up fields to CreateInterfaceRequest as None. Reason for Changes To fix the E0063 Rust compiler errors by including all required fields in the structs. The added fields are set as None since they might not be needed currently.

NerdvanaExplorer commented 6 months ago

Supplementary Error Information and Environment Details:

OS Name: macOS OS Version: 13.6.3 Editor Used: Goland 2023.3.2 Rust Version: rustc 1.77.0-nightly (75c68cfd2 2024-01-07) Git Version: git version 2.37.1 Compilation Errors:

Error 1:

File: src/appstate.rs Line Number: 68 Error Code: E0063 Description: Missing fields post_down and pre_down in the initializer of RemoveInterfaceRequest. Error 2:

File: src/utils.rs Line Number: 78 Error Code: E0063 Description: Missing fields post_up and pre_up in the initializer of CreateInterfaceRequest. Error 3:

File: src/commands.rs Line Number: 74 Error Code: E0063 Description: Missing fields post_down and pre_down in the initializer of RemoveInterfaceRequest.

wojcik91 commented 5 months ago

Hi @NerdvanaExplorer! Thank you very much for your contribution. The pre- and post- commands are a part of ongoing development in the dev branch. They were implemented in https://github.com/DefGuard/client/pull/143. I believe the issue you see could happen if some incorrect version of the protos submodule was checked out along with the main branch of the client. Please make sure to run git submodule update and see if the issue still occurs.

Thanks again and have a great day!