search

DefactoSoftware / Hours

Time registration that doesn't suck
https://happyhours.io
MIT License
1.04k stars 269 forks source link

Update to Rails 5 #541

Closed jurre closed 4 years ago

jurre commented 4 years ago

This updates rails and related dependencies, mostly to fix some security issues.

PS: @tarzan @fatboypunk how do you feel about declaring maintenance mode for the project? We get some pull requests from time to time, but I don't think any of us can really review / accept those. Maybe let's just make it clear that we'll only provide/accept security/dependency updates?

dkhgh commented 4 years ago

declaring maintenance mode

+1 for maintenance mode. I am up for doing a similar project in elixir/phoenix though :)

tarzan commented 4 years ago

Thanks for doing this @jurre , I'm all for maintenance mode -> is that the same as archiving the Repo?

jurre commented 4 years ago

I'm all for maintenance mode -> is that the same as archiving the Repo?

@tarzan not exactly. I was thinking that we would still provide security updates but freeze any feature development. It seems that quite a few people are still using the project and archiving it would prevent us from pushing any updates

jurre commented 4 years ago

@tarzan @dkhgh I've set up a rule to prefer double quoted strings and let rubocop auto fix everything it could. The diff is kind of obnoxious right now, but I think this will improve things going forward.

Never mind, @tarzan already did this 😄