search

DefactoSoftware / test_selector

Elixir library to help selecting the right elements in your tests.
MIT License
14 stars 2 forks source link

Upgraded packages and make hound only available in test mode #33

Closed dkln closed 6 months ago

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.71%. Comparing base (0626f97) to head (129ebba).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #33 +/- ## ======================================= Coverage 85.71% 85.71% ======================================= Files 3 3 Lines 35 35 ======================================= Hits 30 30 Misses 5 5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sn3p commented 6 months ago

Hi @dkln, thanks for the PR!

dkln commented 6 months ago

I made a mistake that by doing this, the app (that uses test-selector) will probably not compile 🤦 I'll try to find a work around for this!

sn3p commented 6 months ago

I made a mistake that by doing this, the app (that uses test-selector) will probably not compile 🤦 I'll try to find a work around for this!

@dkln can you elaborate what the problem is? In any case, we'll wait with creating a new release 😅

sn3p commented 6 months ago

@dkln are you able to find a fix? Otherwise we should maybe revert this change for now. I didn't find the time to test it myself yet..

dkln commented 6 months ago

Sorry @sn3p not yet 😄 Yeah let's revert it and I'll take a look at it when I actually got the time 👍

sn3p commented 6 months ago

@dkln I'm not sure what the problem is, would you care to explain?

@fatboypunk did a similar PR (#32) before as well which I overlooked. Would this suffer the same problems regarding compiling in the app?

fatboypunk commented 6 months ago

https://github.com/DefactoSoftware/test_selector/pull/35 I think this works, hound was still used in some macro's which made it a dependency at compile, and therefore couldn't run. So i've removed all of the hound code. (I think it's not used anymore?)