search

DefangLabs / defang

Defang CLI and sample projects. Defang is a radically simpler way for developers to develop, deploy, and debug cloud applications.
https://defang.io
MIT License
39 stars 9 forks source link

Return nil ProjectUpdate on no bucket #828

Closed lionello closed 3 weeks ago

lionello commented 3 weeks ago

To match the AWS behavior, if no bucket is found we return a nil ProjectUpdate pointer.

lionello commented 3 weeks ago

I don't know, I think it's better to fail loudly here. I think it indicates a system design flaw. (Or the user deleted a bucket manually). We should return an error.

@jordanstephens To me it's the equivalent of https://github.com/DefangLabs/defang/blob/0fa1d166cfe27317a58c792e59f9a2ecc5ccc0b4/src/pkg/cli/client/byoc/aws/byoc.go#L506