search

Defeatomizer / MCreatorVCSPlugin

An unofficial plugin for MCreator to support VCS integration.
https://mcreator.net/plugin/97468/remote-workspaces-support-20232
GNU General Public License v3.0
5 stars 0 forks source link

Plugin is very slow when developing for Minecraft 1.20.1 and below #28

Open BlackCat64 opened 7 months ago

BlackCat64 commented 7 months ago

Issue description

When I click the sync button on my Forge 1.20.1 workspace (not 1.20.4 - only versions below), after typing in the commit name and pressing Enter, the plugin seems to get stuck on the "Pull" stage of loading for a few minutes. It then finally finishes the commit as usual and I can continue working. This issue is very annoying as it means a commit takes about 5 minutes. It doesn't seem to be caused by a new update of MCreator or this plugin, either - it still happened to me on the 2023.4 version, even when I hadn't updated the plugin or MCreator. On 2023.4, the issue also happened on a 1.19.4 workspace, which is where I first encountered it - without having updated anything. My workspace is very large (1500+ elements) so I understand if that's the problem, but it was working fine before, and it still does on 1.20.4, so why is it suddenly so slow for 1.20.1?

How to reproduce this issue?

  1. Open a workspace for Minecraft Forge 1.20.1 or below (in MCreator 2024.1 or 2023.4)
  2. Make sure the workspace is connected to a remote workspace
  3. Click the Sync (Push/Pull) button
  4. Type in a commit name
  5. Click commit

Operating system

Windows

Details

MCreator version: 2024.1, 2023.4 (happens on both)

System Details OS: Windows 10 Processor: AMD Ryzen 5 5600X 6-Core Processor 3.70 GHz Installed RAM: 16.0 GB System type: 64-bit operating system, x64-based processor

Remote repository

https://github.com/BlackCat64/better_tools_and_armor_1.20.1

Logs

No response

Defeatomizer commented 4 months ago

Can you please attach application logs after using the mentioned action?

BlackCat64 commented 2 weeks ago

I have an update on this issue. It turns out the slow speeds are caused by me adding a README.md file to my remote repository, then pulling it into the MCreator workspace. I don't think it has anything to do with the version of Minecraft.

Since I opened this issue, I created a new repository because I was unable to fix the old one being slow: https://github.com/BlackCat64/better_tools_and_armor_remote_1.20.1 I have been using the plugin with this new repo just fine, until recently when I decided to organise my GitHub and add a README for my mod's repository. When I pulled this README file onto my local MCreator workspace, it took a few minutes to load, but it eventually worked and didn't crash. The commits I made on the remote repo now show up correctly in MCreator.

After that, I tested pushing a new file to the repository (a test Hello World procedure), and the commit got stuck on the "Pull" stage for about 5 minutes, even though there were no new changes to pull. Eventually, it made the commit and pushed it successfully, but it also made a "merge commit" alongside it. I don't understand why it's doing this, because I am only ever working on the 'master' branch.

Here is the latest log of my MCreator workspace, when I pulled the README file and then proceeded to push a test procedure. mcreator.log

Operating system Windows

Details MCreator version: 2024.2

System Details OS: Windows 10 Processor: AMD Ryzen 5 5600X 6-Core Processor 3.70 GHz Installed RAM: 16.0 GB System type: 64-bit operating system, x64-based processor