search

DefectDojo / django-DefectDojo

DevSecOps, ASPM, Vulnerability Management. All on one platform.
https://defectdojo.com
BSD 3-Clause "New" or "Revised" License
3.71k stars 1.55k forks source link

Retirejs scans not getting uploaded #1438

Closed praveendvd closed 5 years ago

praveendvd commented 5 years ago

Bug description

Uploading retirejs scan results throws Unicode-objects must be encoded before hashing

Steps to reproduce

  1. Goto Egagements
  2. Upload the Retirejs scan result
  3. Throws unicode erro

Expected behavior

File should parse successfully

Deployment method (select with an X)

Environment information

Sample scan files (optional)

result.zip

Screenshots (optional)

image

Maffooch commented 5 years ago

@devEricA Could you verify and correct? Thanks.

devEricA-zz commented 5 years ago

Fix is done, just awaiting it to be pushed. While I am at it, @praveendvd do you mind if we add your scan to our Sample Scan repository? The reason I ask is because our sample scan for Retire.js hasn't been working for a long time, so I tailored the fix around yours.

praveendvd commented 5 years ago

Fix is done, just awaiting it to be pushed. While I am at it, @praveendvd do you mind if we add your scan to our Sample Scan repository? The reason I ask is because our sample scan for Retire.js hasn't been working for a long time, so I tailored the fix around yours.

Perfect , you can use that report . It doesn't contain any sensitive information as I used OWASP juice shop as the target. Thank you so much for working on this

praveendvd commented 5 years ago

@Maffooch In which commit does this fix available ? or is it yet to be pushed ?

praveendvd commented 5 years ago

I am getting invalid format error in the latest dev commit: 68339f6: Merge pull request #1449 from Maffooch/dev [2019-08-05 11:02:03 -0500]

image

praveendvd commented 5 years ago

@devEricA Thank you guys for looking into this, please let me know if i am on wrong commit

Maffooch commented 5 years ago

@praveendvd So there was a couple issues. At some point, all JSON based parser were broken in the way that raised the exception that you're getting. Not sure when it happened or what broke them though. That was fixed here. The fix motivated from your issue was resolved somewhere in here. I apologize for the confusion!