DefectDojo / django-DefectDojo

DevSecOps, ASPM, Vulnerability Management. All on one platform.
https://defectdojo.com
BSD 3-Clause "New" or "Revised" License
3.74k stars 1.56k forks source link

Bulk finding update - Poor error message: Severity is only required field #248

Closed Greenjam94 closed 7 years ago

Greenjam94 commented 7 years ago

screen shot 2017-03-20 at 1 17 10 pm

I imported issues from Fortify on Demand CSV. There is a severity for all of the issues I imported. However, there's no description, mitigation, or impact fields. When I try to bulk edit to verify all of them, I get the attached error message.

When editing the finding directly, I can see each field is required. The error message just needs to be more accurate maybe something like "Unable to process bulk update. Required fields are invalid, please update individually".

devGregA commented 7 years ago

Hi @Greenjam94 it looks like this is where the error message is located https://github.com/OWASP/django-DefectDojo/blob/master/dojo/test/views.py#L406 would you like to do the PR? :)

@grendel513 anything to add here on why this message is the way it is?

grendel513 commented 7 years ago

No, looks like a good catch. Thanks!

On Tue, Mar 21, 2017 at 9:56 AM, Greg Anderson notifications@github.com wrote:

Hi @Greenjam94 https://github.com/Greenjam94 it looks like this is where the error message is located https://github.com/OWASP/ django-DefectDojo/blob/master/dojo/test/views.py#L406 would you like to do the PR? :)

@grendel513 https://github.com/grendel513 anything to add here on why this message is the way it is?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OWASP/django-DefectDojo/issues/248#issuecomment-288104712, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOQ3gKw9tVFOMVCVcUV0B7H8VxfCs1zks5rn-UMgaJpZM4MiwBg .

devGregA commented 7 years ago

fixed.