DefensePointSecurity / threat_note

DPS' Lightweight Investigation Notebook
Apache License 2.0
421 stars 97 forks source link

'list object' has no attribute 'iteritems' w/ ODNS Investigate enabled #132

Closed k3vb0t closed 8 years ago

k3vb0t commented 8 years ago

I get this error on some queries. I narrowed it down to the ODNS module by checking/un-checking each one(I'm not sure if this is part of an issue I didn't see while looking through).

screen shot 2016-02-11 at 8 54 09 pm

Disabling Investigate returns everything back to the way it should be

screen shot 2016-02-11 at 8 55 48 pm

Confirming it works using a different domain

screen shot 2016-02-11 at 8 57 38 pm

I'm not sure if anyone looked into it, but there is an officially supported ODNS Investigate module(bias:I work there):

https://github.com/opendns/pyinvestigate

alxhrck commented 8 years ago

Another OpenDNS tester! Definitely a logic bug. I haven't done much validation checking on whether or not results are returned from the API, which I'll fix over the next couple of days.

Moving to using pyinvestigate is a good idea, I'll also start working on that.

k3vb0t commented 8 years ago

If I get some time over the weekend I can see what I can do with the ODNS importation, I'm pretty familiar with it :smile: No promises though.

k3vb0t commented 8 years ago

Issue resolved