search

DefensePointSecurity / threat_note

DPS' Lightweight Investigation Notebook
Apache License 2.0
421 stars 97 forks source link

modal-backdrop covering "New Attribute" modal #152

Open spencerwp opened 8 years ago

spencerwp commented 8 years ago

The modal popup when trying to add a new attribute on an object gets covered by the backdrop. This is a known bootstrap 3 issue, which can be caused by a parent node of the modal having its position set to something other than default.

The ".main-panel" div on the page "neweditobject.html" is the parent of the modal, which has its position set to relative. Moving the modal to outside of the ".main-panel" div in the same HTML template fixes this issue. The div/form/fieldset are out of order in this template, so I did not PR my fix, as I'm not sure if that was on purpose (I changed mine to proper order and did not notice anything breaking).

brianwarehime commented 8 years ago

Yea, I need to still fix the New Attribute page, but, I don't believe it was intentional. Feel free to submit a PR if it fixes the issue. Thanks!

infracritical commented 6 years ago

Any possibility of getting this identified for the HTML file?

donfranke commented 5 years ago

I was able to fix this by doing the following:

  1. cd to static/css directory
  2. wget https://stackpath.bootstrapcdn.com/bootstrap/3.4.0/css/bootstrap.css
  3. edit bootstrap.css, for .modal-backdrop change z-index from 1040 to 1
  4. edit /templates/header.html, change bootstrap.min.css to bootstrap.css

However...work remains to support saving the attribute to the database. This just fixes the UI issue.