search

Deffiss / testenvironment-docker

MIT License
117 stars 30 forks source link

Extract shared wait container logic to the separate class #19

Closed vhatsura closed 4 years ago

aharshkalep commented 4 years ago

Nice to see such contribution, I'll review that shortly and investigate why CI/CD is failed.

vhatsura commented 4 years ago

Nice to see such contribution, I'll review that shortly and investigate why CI/CD is failed.

I see the reason. Forgot to rewrite HttpContainerWaiter which is used in the Release configuration of tests. I've fixed it

aharshkalep commented 4 years ago

Generally, PR looks good. Are you expecting new version to be published after we merge it? Did you fix an issue and want to get the fix through the nuget? @Hellevar , What do you think?

vhatsura commented 4 years ago

Generally, PR looks good. Are you expecting new version to be published after we merge it? Did you fix an issue and want to get the fix through the nuget?

Changes don't fix anything except some not important cases of exception throwing. The PR is preparation for the more advanced feature: get error logs from the container for a better understanding of what is wrong

aharshkalep commented 4 years ago

Changes don't fix anything except some not important cases of exception throwing. The PR is preparation for the more advanced feature: get error logs from the container for a better understanding of what is wrong

Got It. So no needs to publish new version of packages.