search

Deffiss / testenvironment-docker

MIT License
117 stars 30 forks source link

Use 'Filters' parameter in place of 'Filter' -> removed from docker API Image List Query Parameters #47

Closed dgvives closed 3 years ago

dgvives commented 3 years ago

Update docker API call to remove discarded 'Filter' parameter when querying images. Replaced by 'Filters'

Docker.DotNet library doesn't reflect this change on docker API and image pulling was failing. https://docs.docker.com/engine/api/v1.41/#operation/ImageList

Deffiss commented 3 years ago

@Hellevar any comments?

Hellevar commented 3 years ago

Looks good to me. But could you also bump versions of main package and all others to reflect this change?

dgvives commented 3 years ago

First time ever contribution for me. Do you mean to reflect the same change in original Docker.DotNet package?

Hellevar commented 3 years ago

No, i mean that you need to manually bump minor versions of all projects in our solution (in .csproj files).

Deffiss commented 3 years ago

I think I can bump up versions by myself after merging.

dgvives commented 3 years ago

Thanks for @Hellevar and @Deffiss for your support on my contribution, and congrats for this fine piece of work. :+1: