search

Deffiss / testenvironment-docker

MIT License
117 stars 30 forks source link

Switch from deprecated SQL Server container image #49

Closed romansp closed 3 years ago

romansp commented 3 years ago

Noticed that container image for SQL Server microsoft/mssql-server-linux was marked as deprecated. I went ahead and updated defaults to mcr.microsoft.com/mssql/server.

As of today image at mcr.microsoft.com/mssql/server:latest is SQL Server 2019, so this could potentially be a breaking change for someone who relies on SQL Server 2017.

Deffiss commented 3 years ago

Hi, @romansp , thanks for noticing that. @Hellevar what do you think?

jzabroski commented 3 years ago

I think you should bump the major version number on TestEnvironment.Docker nuget package, document the breaking change in release notes, and call it a day.

Deffiss commented 3 years ago

Well, yeah, we need to bump up TestEnvironment.Docker.Mssql version for sure.

Hellevar commented 3 years ago

Looks good for me, please bump sql server package version (for example to 1.1.0) and add short description to PackageReleaseNotes

romansp commented 3 years ago

For anyone else experiencing issues with mcr.microsoft.com/mssql/server image. We were hitting an problem on Bitbucket Pipelines where test host will get terminated early due to insufficient memory. Default memory limit for Docker service on Bitbucket is 1GB (can be increased though) which is supposedly not enough for MSSQL to run properly. There are multiple opened issues about memory utilization in their repo: https://github.com/microsoft/mssql-docker/issues

After reverting back to 1.0.10 the problem went away. It can probably be solved with some additional container tweaking but we decided to stick to older package while it works.