search

Deffiss / testenvironment-docker

MIT License
117 stars 30 forks source link

Docker.DotNet package requires update to latest version #69

Closed Lukino closed 1 year ago

Lukino commented 1 year ago

When I update Docker.DotNet 3.125.12, testenvironment-docker started to thow exception, because DockerClientConfiguration constructors. Here is change log https://github.com/dotnet/Docker.DotNet/compare/v3.125.5...v3.125.12#diff-a944f48314882e7cae293af14f782fdae674e6af5e12fc2f0abeb705cd3c17b7R19

Lukino commented 1 year ago

70 Pull request

Deffiss commented 1 year ago

Hi, @Lukino Thanks for reporting the issue. Let me review your PR.

Deffiss commented 1 year ago

Could you please clarify about the reason of upgrading the library? Is it for keeping it up to date or there is a desired functionality in a latest version?

Lukino commented 1 year ago

It causes constructor error during tests run.

Message:  System.MissingMethodException : Method not found: 'Void Docker.DotNet.DockerClientConfiguration..ctor(System.Uri, Docker.DotNet.Credentials, System.TimeSpan)'.

Stack Trace:  DockerClientExtentions.CreateDefaultDockerClient() DockerEnvironmentBuilder.ctor(ILogger logger) IntegrationFixture.PrepareDockerEnvironment(Boolean useContainerIpAddresses, SqlContainerSettings settings) line 127 IntegrationFixture.InitializeAsync() line 68

Lukino commented 1 year ago

@Deffiss Do you have any estimation for new release ?

Deffiss commented 1 year ago

@Lukino - just released, please wait for few minutes until it becomes available.

Deffiss commented 1 year ago

I am going to close this issue. Please, let me know if it is not fixed yet for some reasons.

Lukino commented 1 year ago

Yep, new version works fine. Thanks